Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for bor module #1071

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Add README for bor module #1071

merged 5 commits into from
Oct 4, 2023

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Oct 3, 2023

Description

This PR adds a README for bor module.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@Raneet10 Raneet10 requested review from 0xKrishna and a team October 3, 2023 12:15
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, LGTM. Just a few suggestions.

bor/README.md Outdated Show resolved Hide resolved
bor/README.md Outdated Show resolved Hide resolved
bor/README.md Outdated Show resolved Hide resolved
bor/README.md Show resolved Hide resolved
bor/README.md Outdated Show resolved Hide resolved
bor/README.md Outdated Show resolved Hide resolved
bor/README.md Outdated Show resolved Hide resolved
@Raneet10 Raneet10 merged commit f7decae into develop Oct 4, 2023
9 of 10 checks passed
@Raneet10 Raneet10 deleted the raneet10/pos-1793 branch October 4, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants