Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge V1.0.3 candidate to master #1101

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Merge V1.0.3 candidate to master #1101

merged 2 commits into from
Nov 3, 2023

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Nov 3, 2023

Description

PR to merge v1.0.3-candidate to master.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

ssandeep and others added 2 commits November 2, 2023 20:38
@ssandeep @VAIBHAVJINDAL3012
Vaibhav/bug fix (#1097)
56299da 
* Added extra check in the unpack fn

* Added the unit test cases

* updated the version to v1.0.3

---------

Co-authored-by: Vaibhav Jindal <vaibhavjindal29@gmail.com>
@Raneet10
staking: fix lint
cb7aa51
@Raneet10 Raneet10 requested a review from a team November 3, 2023 06:52
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@Raneet10 Raneet10 merged commit 1842793 into master Nov 3, 2023
12 checks passed
@Raneet10 Raneet10 deleted the v1.0.3-candidate branch November 3, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xsharma 0xsharma 0xsharma approved these changes

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Raneet10 @0xsharma @pratikspatil024 @ssandeep