Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server README #1125

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Server README #1125

merged 2 commits into from
Jan 14, 2024

Conversation

0xKrishna
Copy link
Contributor

Description

Added Server README

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@0xKrishna 0xKrishna changed the base branch from master to develop January 4, 2024 05:22
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2e1ae1) 76.59% compared to head (c6759a3) 76.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1125   +/-   ##
========================================
  Coverage    76.59%   76.59%           
========================================
  Files           53       53           
  Lines         5922     5922           
========================================
  Hits          4536     4536           
  Misses        1128     1128           
  Partials       258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xKrishna 0xKrishna requested a review from a team January 5, 2024 06:43
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit 2fec0f8 into develop Jan 14, 2024
11 of 12 checks passed
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 deleted the pos-1827 branch January 14, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants