Revert "clerk/client/rest :: add : blocktime check in recordListHandlerFn" #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1127 +/- ##
========================================
Coverage 76.59% 76.59%
========================================
Files 53 53
Lines 5922 5922
========================================
Hits 4536 4536
Misses 1128 1128
Partials 258 258 ☔ View full report in Codecov by Sentry. |
pratikspatil024
approved these changes
Jan 16, 2024
temaniarpit27
approved these changes
Jan 16, 2024
Raneet10
approved these changes
Jan 16, 2024
marcello33
approved these changes
Jan 16, 2024
|
This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #993 as discussed in RFC 225.
The aim of this reversion is to prevent bor chain to halt when there's an outage on heimdall chain. With no checks on time, heimdall will return 0 (or less than expected) state-sync transactions unblocking bor to proceed. Although it may lead to bad block, it won't impact the liveness of bor.