Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for matic-cli dockerized tests #1139

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Mar 4, 2024

Description

Based on matic-cli PR, this adapts the path accordingly also in heimdall integration tests

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@marcello33 marcello33 changed the base branch from master to develop March 4, 2024 15:45
@marcello33 marcello33 mentioned this pull request Mar 4, 2024
12 tasks
@marcello33 marcello33 requested a review from a team March 4, 2024 15:53
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (5b91534) to head (9bc119f).

❗ Current head 9bc119f differs from pull request most recent head 36a8246. Consider uploading reports for the commit 36a8246 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1139   +/-   ##
========================================
  Coverage    76.59%   76.59%           
========================================
  Files           53       53           
  Lines         5922     5922           
========================================
  Hits          4536     4536           
  Misses        1128     1128           
  Partials       258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 merged commit 0c70e02 into develop Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants