Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge, staking: chg: bug fix #1149

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

marcello33
Copy link
Contributor

Description

This PR fixes a bug in staking module.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Nodes audience

Valid for all nodes, required for validators.

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy
  • I have created new e2e tests into express-cli

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (98ba715) to head (7fc00b1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
- Coverage   76.59%   76.40%   -0.20%     
==========================================
  Files          53       53              
  Lines        5922     5929       +7     
==========================================
- Hits         4536     4530       -6     
- Misses       1128     1139      +11     
- Partials      258      260       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 requested a review from a team March 18, 2024 16:12
@marcello33 marcello33 merged commit e95c69d into maticnetwork:master Mar 18, 2024
10 of 11 checks passed
@marcello33 marcello33 deleted the mardizzone/bb-29138 branch May 23, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants