Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS-2399: ganache bug workaround to reduce smoke_test time in CI #1164

Merged
merged 1 commit into from
May 23, 2024

Conversation

marcello33
Copy link
Contributor

Description

This PR cherry picks the implementation of the workaround for the ganache bug to reduce the smoke_test execution time during CI.
This has been running fine on develop for some time now.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy
  • I have created new e2e tests into express-cli

…1141)

* chg: POS-2399: ganache bug workaround to reduce smoke_test time

* chg: POS-2399: add echo log

* chg: POS-2399: fix signer dump path

* chg: POS-2399: log info

* chg: POS-2399: fix script with proper signersDump length

* chg: POS-2399: better comment
@marcello33 marcello33 requested a review from a team May 23, 2024 15:10
@marcello33 marcello33 merged commit f42d25c into master May 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants