Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAT 141 - Start bridge only when node is synced #79

Merged
merged 5 commits into from Nov 8, 2019
Merged

MAT 141 - Start bridge only when node is synced #79

merged 5 commits into from Nov 8, 2019

Conversation

vaibhavchellani
Copy link
Contributor

Starts bridge services only when node is synced

@vaibhavchellani
Copy link
Contributor Author

Testing underway

@vaibhavchellani vaibhavchellani changed the title Start bridge only when node is synced MAT 141 Start bridge only when node is synced Oct 21, 2019
@vaibhavchellani vaibhavchellani changed the title MAT 141 Start bridge only when node is synced MAT 141 - Start bridge only when node is synced Oct 21, 2019
jdkanani
jdkanani approved these changes Oct 21, 2019
View reviewed changes
bridge/pier/common.go Outdated

// IsSynced checks if the heimdall node you are connected to is fully synced or not
// returns true when synced
func IsSycned(cliCtx cliContext.CLIContext) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo: IsSynced

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!

mankenavenkatesh
mankenavenkatesh approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@mankenavenkatesh mankenavenkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaibhavchellani
Copy link
Contributor Author

@jdkanani @mankenavenkatesh please sqash and merge

mankenavenkatesh
mankenavenkatesh approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@mankenavenkatesh mankenavenkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mankenavenkatesh mankenavenkatesh merged commit 5e324c6 into master Nov 8, 2019
@jdkanani jdkanani deleted the bridge-enhancement branch November 10, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdkanani jdkanani jdkanani approved these changes

@mankenavenkatesh mankenavenkatesh mankenavenkatesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavchellani @jdkanani @mankenavenkatesh