Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Stop the rotation of validatorSet at any update in it. #983

Merged
merged 4 commits into from Aug 24, 2023

Conversation

VAIBHAVJINDAL3012
Copy link
Contributor

Description

In the current system, at every update in validatorSet, we rotate it and change the proposer. With the frequent updates, proposer also changes frequently.
This PR include the change which has stopped the rotation of validatorSet in endBlocker after any update in the validatorSet.
Implementation of this change require the Hardfork.

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • [✓] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • [✓] Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

This change require the Hardfork.

Nodes audience

It needs to deployed on all the validator nodes.

Checklist

  • [ ✓] I have added at least 2 reviewer or the whole pos-v1 team
  • [✓] I have added sufficient documentation in code
  • [✓] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • [✓] I have tested this code manually on local environment
  • [✓] I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (c7ec9d5) 75.40% compared to head (fc117bf) 75.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #983      +/-   ##
===========================================
- Coverage    75.40%   75.38%   -0.02%     
===========================================
  Files           49       49              
  Lines         5309     5310       +1     
===========================================
  Hits          4003     4003              
- Misses        1071     1072       +1     
  Partials       235      235              
Files Changed Coverage Δ
app/app.go 82.64% <0.00%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 changed the title Fix:Stop the rotation of validatorSet at any update in it. Fix:Stop the rotation of validatorSet at any update in it. [Don't merge it] Apr 18, 2023
@github-actions
Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 10, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 35 days with no activity.

@github-actions
Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 7, 2023
@pratikspatil024 pratikspatil024 marked this pull request as draft July 11, 2023 04:56
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 2, 2023
@temaniarpit27 temaniarpit27 changed the title Fix:Stop the rotation of validatorSet at any update in it. [Don't merge it] Fix:Stop the rotation of validatorSet at any update in it. Aug 3, 2023
@temaniarpit27 temaniarpit27 marked this pull request as ready for review August 24, 2023 07:42
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit 727a29a into develop Aug 24, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants