Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add : get latest checkpoint count from main chain #117

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Conversation

nikhil0360
Copy link
Contributor

In this PR, we add the ability to check Checkpoint count on Root chain for further debugging in --monitor command. It was previously checked only on heimdall.

Copy link
Contributor

@0xsharma 0xsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rootChainProxyAddress is not constant as its not a genesis contract. You need to get the address of the deployment from contractAddresses.json.

Copy link
Contributor

@0xsharma 0xsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congrats on your first PR!

@nikhil0360 nikhil0360 merged commit b1861ed into master Nov 23, 2022
@0xsharma 0xsharma deleted the nikhil/POS-1009 branch November 23, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants