Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to system process from tmux #91

Merged
merged 47 commits into from
Nov 9, 2022
Merged

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Nov 3, 2022

Description

This PR migrates the network which was previously run in tmux sessions to systemd processes, which is useful while checking logs and gives resemblance to the way our actual mainnet/testnet nodes are run.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

src/express/commands/start.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/express/commands/cleanup.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/express/commands/cleanup.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Show resolved Hide resolved
src/setup/devnet/index.js Show resolved Hide resolved
src/setup/devnet/index.js Show resolved Hide resolved
src/setup/devnet/index.js Show resolved Hide resolved
src/setup/devnet/templates/remote/service-host.sh Outdated Show resolved Hide resolved
src/setup/devnet/templates/remote/service-host.sh Outdated Show resolved Hide resolved
src/setup/devnet/templates/remote/service-host.sh Outdated Show resolved Hide resolved
src/setup/devnet/templates/remote/service.sh Outdated Show resolved Hide resolved
src/setup/devnet/templates/remote/service.sh Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
src/setup/devnet/index.js Outdated Show resolved Hide resolved
@Raneet10 Raneet10 marked this pull request as ready for review November 7, 2022 10:38
@marcello33 marcello33 self-requested a review November 9, 2022 11:47
@marcello33 marcello33 merged commit 5f62613 into master Nov 9, 2022
@marcello33 marcello33 deleted the raneet10/pos-878 branch November 30, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants