Support typed tx #89
Merged
Support typed tx #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzmeanjan
reviewed
Jul 28, 2021
| @@ -17,3 +17,5 @@ test-blockchain/start.sh | |||
| contractAddresses.json | |||
|
|
|||
| tenderly.yaml | |||
|
|
|||
| contracts/ChainConstants.sol | |||
There was a problem hiding this comment.
We can probably remove this.
There was a problem hiding this comment.
I suspect it is a generated file (it was newly created in the repo) that's why I ignored it to avoid committing. Any reasons to not do it?
jdkanani
approved these changes
Jul 28, 2021
added 4 commits
August 2, 2021 19:26
Done to avoid changing of existing contracts
jdkanani
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-2718 introduced typed transactions and corresponding typed receipts. If tx is not legacy, it requires to prepend a
typebyte in front of RLP encoded receipt bytes.This case is not handled in POS bridge
RootChainManager. A user will not able to exit with a typedwithdrawtransaction.This PR modifies how receipt bytes are parsed to handle typed receipts.