Remove exit payload length check #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyourm8
approved these changes
Sep 20, 2021
jdkanani
approved these changes
Sep 20, 2021
|
Hej jag vet inte om jag är hackad håller på med försöker att få allt att fungera på denna enhet till jag har råd att köpa en ny dator.tack en en gång |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
Sometime ago I added check for decoded exit payload length (
assert length == 10), in PR #85. After that we merged PR #89, which added an wrapper around proof reader library. During merge, proof length check was misplaced, added before decoding, resulting into failing exit payload length check withBAD_PAYLOAD.I'm removing this length check, it doesn't cause any major problem because anyway if some one submits proof of wrong length, if will be failing during decoding.