fix: Add peer closed WebSocket handling introduced in StarScream 4.0.5 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call it before app resigns active, so OS won't abort the connection like this: Receive failed with error "Software caused connection abort"
…Operation to re-execute it when needed.
…eric parameter shadowing generic parameter from outer scope with the same name
…5. According to RFC 6455 RFC 6455 7.1.5 says: If _The WebSocket Connection is Closed_ and no Close control frame was received by the endpoint (such as could occur if the underlying transport connection is lost), _The WebSocket Connection Close Code_ is considered to be 1006
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@maticzav This looks to me as a breaking change if someone, who uses WebSocket has a switch without a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 6455 7.1.5 says: