Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surrounding underscores are now correctly supported #164

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Surrounding underscores are now correctly supported #164

merged 3 commits into from
Oct 18, 2023

Conversation

shaps80
Copy link
Collaborator

@shaps80 shaps80 commented Oct 4, 2023

Resolves #123 (apologies for creating a new PR but there were several other issues I needed to resolve ASAP)

Note: I only came across this repo a couple hours ago, so I might have missed something and not actually resolved the issue.

That said, I had several issues when I tried to integrate with the latest release due to non-compile:

  1. Starscream APIs were not implemented correctly (perhaps there was a breaking update?) so I had to update the Delegate implementations
  2. Our Schema uses underscores in both leading and trailing placements, so I needed to update the camelCase method to preserve this.

This API resolves all of the above such that the project now compiles again and the updated tests pass.

I did notice however that some of the socket tests are failing (they were before my changes) but I'm unsure how best to resolve those.


EDIT

I just realised a couple of the other PRs also solve the Starscream updates. I can remove my fixes is you prefer to merge one of the other PRs first. Just let me know 👍

Closes #162 #123

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swift-graphql ❌ Failed (Inspect) Oct 12, 2023 10:43am

@shaps80 shaps80 merged commit fd54087 into maticzav:main Oct 18, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants