Fixed available tag in generator
#163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shaps80
reviewed
Oct 12, 2023
| @@ -91,7 +91,9 @@ extension Field { | |||
| if isDeprecated { | |||
| // NOTE: It's possible that a string contains double-quoted characters in deprecation reason. | |||
| // http://spec.graphql.org/October2021/#sec-Language.Directives | |||
| let message = deprecationReason?.replacingOccurrences(of: "\"", with: "\\\"") ?? "" | |||
| let message = deprecationReason? | |||
| .trimmingCharacters(in: .whitespacesAndNewlines) | |||
There was a problem hiding this comment.
The Swift version also can support multiple line messages, which can improve readability so I'd suggest we retain that?
@available(*, deprecated, message: """
Line 1
Line 2
""")Could we just check for a newline character, and if it exists, we use this alternative multi-line string instead to ensure we retain the documentation as it was intended?
|
#169 provides a multiline solution that will automatically close this PR once its merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an issue where the generator would write an
availablestring that could potentially include multi-line statements.