Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OPAM file for eff. #15

Merged
merged 1 commit into from Oct 27, 2015
Merged

Add an OPAM file for eff. #15

merged 1 commit into from Oct 27, 2015

Conversation

yallop
Copy link
Contributor

@yallop yallop commented Mar 27, 2015

This should makes the installation instructions a little simpler. Once you have OPAM installed you can switch to a suitable OCaml compiler (opam switch 4.02.1) and then run

opam pin add eff git@github.com:matijapretnar/eff.git

to download the dependencies and build and install eff.

@andrejbauer
Copy link
Collaborator

Surely we do not require 4.02 for eff to compile.

@yallop
Copy link
Contributor Author

yallop commented Mar 28, 2015

Perhaps not; I was going by the README, which says:

To install Eff, you need a standard Unix-style build environment as well as

  1. OCaml, version 4.02 or newer, and

@yallop
Copy link
Contributor Author

yallop commented Mar 28, 2015

I tried building it with a few OCaml versions going back to 3.12.1, and it worked with all of them, so I've removed the OCaml version constraint.

@andrejbauer
Copy link
Collaborator

Excellent, many thanks.

@matijapretnar
Copy link
Owner

Do you both agree we can switch to OCaml 4.02? I want to get rid of

Warning 3: deprecated: String.set
Use Bytes.set instead.

warnings. Anyone not willing to upgrade their OCaml can use the new online toplevel instead.

@andrejbauer
Copy link
Collaborator

I think it's more important to allow compilation with older Ocaml versions than getting rid of a warning like that.

@yallop
Copy link
Contributor Author

yallop commented Oct 27, 2015

One way to avoid the warning is to use the bytes package (distributed with OCamlfind) that provides an implementation of the bytes module for older OCaml versions.

Alternatively, you could add true: warn(-3) to the bottom of the _tags file to turn off warnings about deprecated features.

@matijapretnar
Copy link
Owner

Okay. Let's keep things simple then and stick with the warning for now. We'll switch to OCaml 4 as soon as we find something that we would like that 3.12 doesn't support.

matijapretnar added a commit that referenced this pull request Oct 27, 2015
Add an OPAM file for eff.
@matijapretnar matijapretnar merged commit 48b9253 into matijapretnar:master Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants