Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Galaxy Note 7 #5551

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Detect Galaxy Note 7 #5551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Tests/fixtures/phablet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,6 +1607,26 @@
model: GALAXY Note 4 Edge
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 6.0.1; SM-N930F Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.98 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: "6.0.1"
platform:
client:
type: browser
name: Chrome Mobile
short_name: CM
version: "52.0.2743.98"
engine: Blink
engine_version:
device:
type: phablet
brand: SA
model: Galaxy Note 7
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 6.0.1; SM-N920C Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.81 Mobile Safari/537.36
os:
Expand Down
3 changes: 3 additions & 0 deletions regexes/device/mobiles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3662,6 +3662,9 @@ Samsung:
- regex: '(?:SAMSUNG-)?GT-I920[05]'
model: 'GALAXY Mega 6.3'
device: 'phablet'
- regex: '(?:SAMSUNG-)?SM-N930F'
model: 'Galaxy Note 7'
device: 'phablet'

# explicit feature phones
- regex: '(?:SAMSUNG-)?GT-E2152'
Expand Down