Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Instacast only as a mobile app. #5793

Merged
merged 6 commits into from
Sep 6, 2018
Merged

Detect Instacast only as a mobile app. #5793

merged 6 commits into from
Sep 6, 2018

Conversation

etienne-martin
Copy link
Contributor

Related to this issue: #5792

@etienne-martin
Copy link
Contributor Author

I also added an additional test not related to the issue mentioned above.

I discovered that line 692 of DeviceDetector.php (https://github.com/matomo-org/device-detector/blob/master/DeviceDetector.php#L692) was not covered by any tests.

@sgiehl sgiehl merged commit 0910ab4 into matomo-org:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants