Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for various apps and browsers #7165

Merged
merged 15 commits into from
Jul 7, 2022

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

@liviuconcioiu
Copy link
Collaborator Author

@sanchezzzhak I've noticed that there are a bunch of browser tests in Tests/fixtures/clienthints-app.yml. Should I moved them to Tests/Parser/Client/fixtures/browser.yml?

@sanchezzzhak
Copy link
Collaborator

you can, transfer all browsers

those browsers that are masked for the desktop should be left
example

-
  user_agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36
  headers:
    x-requested-with: com.appssppa.idesktoppcbrowser
  os:
    name: Android
    version: ""
    platform: "x64"
  client:
    type: browser
    name: iDesktop PC Browser
    version:
    engine: Blink
    engine_version: 52.0.2743.116
  device:
    type: tablet
    brand: ""
    model: ""
  os_family: Android
  browser_family: Chrome

@sanchezzzhak sanchezzzhak merged commit 55b7010 into matomo-org:master Jul 7, 2022
@liviuconcioiu liviuconcioiu deleted the browsers1 branch July 7, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants