New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--idsite option seems to be ignored when used with --reply-tracking #97

Closed
tsteur opened this Issue Aug 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Aug 27, 2015

It looks like it's set initially here https://github.com/piwik/piwik-log-analytics/blob/master/import_logs.py#L1591
and then overwritten here https://github.com/piwik/piwik-log-analytics/blob/master/import_logs.py#L1600

Example command:

/home/vagrant/www/piwik/misc/log-analytics/import_logs.py --url=http://apache.piwik/ --replay-tracking '/home/vagrant/www/testfiles/ecommerce_idsite_5.log' --idsite=5 2>&1

To test it one can use eg the ecommerce log file from Piwik repository: plugins/VisitorGenerator/data/ecommerce.log

It's weird as I thought I tested it initially and worked but now realize that it doesn't work. Also I'm not 100% if it's a bug or feature but does sound like a bug to me. Would need this feature for a custom plugin.

@tsteur tsteur added the bug label Aug 27, 2015

@tsteur tsteur added this to the Current sprint milestone Aug 27, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 31, 2015

Member

It's weird as I thought I tested it initially and worked but now realize that it doesn't work. Also I'm not 100% if it's a bug or feature but does sound like a bug to me.

👍 if --idsite is set, then it should be applied at all times (it's a useful feature too)

Member

mattab commented Aug 31, 2015

It's weird as I thought I tested it initially and worked but now realize that it doesn't work. Also I'm not 100% if it's a bug or feature but does sound like a bug to me.

👍 if --idsite is set, then it should be applied at all times (it's a useful feature too)

tsteur added a commit to matomo-org/matomo that referenced this issue Aug 31, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 31, 2015

Member

@diosmosis do you mind having a look at #99 ?

Member

tsteur commented Aug 31, 2015

@diosmosis do you mind having a look at #99 ?

@tsteur tsteur self-assigned this Aug 31, 2015

@diosmosis diosmosis closed this in #99 Sep 1, 2015

diosmosis added a commit that referenced this issue Sep 1, 2015

Merge pull request #99 from piwik/97
Fixes #97, make sure to always apply site_id if specified via option, even when --replay-tracking is used

diosmosis added a commit to matomo-org/matomo that referenced this issue Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment