Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly sort glob results for an implicit progress bar #292

Merged
merged 1 commit into from Nov 18, 2020
Merged

explicitly sort glob results for an implicit progress bar #292

merged 1 commit into from Nov 18, 2020

Conversation

Prinzhorn
Copy link
Contributor

@Prinzhorn Prinzhorn commented Nov 18, 2020 •
edited by Findus23

fixes #291

@Findus23
Copy link
Member

Seem reasonable to me as unsorted globs can be annoying and sorting the list of filenames should never have a relevent performance impact.

@sgiehl sgiehl changed the title explicitly sort glob results for an implicit progress bar, fixes #291 explicitly sort glob results for an implicit progress bar Nov 18, 2020
@sgiehl sgiehl merged commit 04657aa into matomo-org:4.x-dev Nov 18, 2020
@Prinzhorn
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly sort globs for implicit progress bar
3 participants
@Prinzhorn @Findus23 @sgiehl