Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude bower.json, .bower.json and .bowerrc from archive (zip/tar.gz) #21

Closed
aureq opened this issue Jan 15, 2015 · 7 comments
Closed

Comments

@aureq
Copy link
Contributor

aureq commented Jan 15, 2015

hi @mattab @mnapoli

I found a lot of bower.json, .bower.json files and one .bowerrc.
The .deb already exclude these as it seems to be related to bower package management and dependencies.
Let me know if I also should exclude these from the official archives as well.

Cheers

@aureq aureq added the bug label Jan 15, 2015
@aureq
Copy link
Contributor Author

aureq commented Jan 15, 2015

Also, unsure about

  • .travis.yml
  • composer.json
  • .coveralls.yml
  • libs/bower_components/jquery-ui/ui/.jshintrc
  • .editorconfig
  • libs/PiwikTracker/.git
  • .scrutinizer.yml

Let me know if safe to be removed from the release.

@mnapoli
Copy link
Contributor

mnapoli commented Jan 16, 2015

Hi, indeed we could, though maybe not composer.json because it might be used in the future.

Is there any reason to remove them? I wouldn't go though that trouble if they don't affect anything, especially since they may change in the future.

@aureq
Copy link
Contributor Author

aureq commented Jan 16, 2015

It's mostly for cleanliness purpose.

@mnapoli
Copy link
Contributor

mnapoli commented Jan 16, 2015

OK I'm in theory +1 for that, I'm just afraid of possible side effects later if things changes. E.g. I would not remove composer.json files. The rest should be OK I guess.

@aureq
Copy link
Contributor Author

aureq commented Jan 16, 2015

ok, will do, thanks.

@aureq aureq closed this as completed in 7db4c78 Jan 16, 2015
@mattab
Copy link
Member

mattab commented Jan 16, 2015

+1 with @mnapoli point

@tomduckering
Copy link

Some of these files (i.e. bower.json) are still included in the manifest.inc.php. This seems to cause warnings in the File Integrity section of the System Check Administration page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants