autoload.php files don't get deleted, but ignored from integrity checker #77
Comments
Findus23
changed the title
|
FYI. I will remove the autoload.php from device detector for upcoming composer packages again. Doesn't make sense to have it in this case, as composer handles the autoloading... |
The reason we excluded them from manifest is because IIRC the files contain some random hash that changes depending on the server or so, so the manifest was failing. |
|
So actually we could fix the package script and only specifically grep out 'vendor/autoload.php' and 'vendor/composer/autoload_real.php' and leave any other 'autoload.php' in the manifest file. |
mattab
added a commit
that referenced
this issue
Sep 1, 2018
3.6.0 was re-packaged and 3.6.1 released to fix this issue except the main composer ones which can change from server to server IIRC fixes matomo-org/matomo#13364 and #77
|
fixed in 2a683a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following line excludes
manifest.inc.php|autoload.php|autoload_real.phpfiles from the manifest.inc.php even when they don't get deleted. This causes the integrity checker to warn (see matomo-org/matomo#13364 and matomo-org/matomo#13318)matomo-package/scripts/build-package.sh
Line 271 in 11c5f9c
This didn't happen before, because only in 3.6.0 I added sparklines which has an autoload.php file and @sgiehl added an autoload.php to DeviceDetector in matomo-org/device-detector#5742
@mattab, @tsteur Is there a reason for this line?
The text was updated successfully, but these errors were encountered: