Piwik Debian package: Apache2 improvements #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aureq
suggested changes
Oct 15, 2017
debian/piwik.postinst
Outdated
| if [ ! -e /etc/apache2/conf-available/piwik.conf ]; | ||
| then | ||
| ln -s /etc/piwik/apache.conf /etc/apache2/conf-available/piwik.conf | ||
| ln -s /etc/apache2/conf-available/piwik.conf /etc/apache2/conf-enabled/piwik.conf |
There was a problem hiding this comment.
a2enconf --maintmode piwik should be called instead.
debian/piwik.postrm
Outdated
|
|
||
| if [ -L /etc/apache2/conf-available/piwik.conf ]; | ||
| then | ||
| rm -f /etc/apache2/conf-available/piwik.conf |
There was a problem hiding this comment.
a2disconf --maintmode piwik should be called instead
debian/piwik.postrm
Outdated
| if [ -L /etc/apache2/conf-available/piwik.conf ]; | ||
| then | ||
| rm -f /etc/apache2/conf-available/piwik.conf | ||
| if [ -L /etc/apache2/conf-enabled/piwik.conf ]; |
There was a problem hiding this comment.
Should be removed after a2disconf is called.
|
Made those changes, aureq. thanks for the positive feedback. |
|
@dg01d Thanks, that's now merged. Following your work, the package attempts to be smarter by detecting previous installations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches following:
piwik.postinst&piwik.rminstInserts logic to deal with Debian 8+
/etc/apache2/conf-availableconfiguration locationconf/apache.confReferences
/etc/apache2/conf-availablein header comments