Refs #5113 This may fix the bug where Outlinks are marked as "Page na…

…me not defined".

Let's see which integration tests now fail

core/Tracker/Action.php

@@ -250,25 +250,22 @@ public function record($idVisit, $visitorIdCookie, $idReferrerActionUrl, $idRefe
     {
         $this->loadIdsFromLogActionTable();
 
-        $idActionName = in_array($this->getActionType(), array(Tracker\Action::TYPE_PAGE_TITLE,
-                                                               Tracker\Action::TYPE_PAGE_URL,
-                                                               Tracker\Action::TYPE_SITE_SEARCH
-                                                         ))
-            ? (int)$this->getIdActionName()
-            : 0;
-
         $visitAction = array(
             'idvisit'               => $idVisit,
             'idsite'                => $this->request->getIdSite(),
             'idvisitor'             => $visitorIdCookie,
             'server_time'           => Tracker::getDatetimeFromTimestamp($this->request->getCurrentTimestamp()),
             'idaction_url'          => $this->getIdActionUrl(),
-            'idaction_name'         => $idActionName,
             'idaction_url_ref'      => $idReferrerActionUrl,
             'idaction_name_ref'     => $idReferrerActionName,
             'time_spent_ref_action' => $timeSpentReferrerAction
         );
 
+        // idaction_name is NULLable. we only set it when applicable
+        if($this->isActionHasActionName()) {
+            $visitAction['idaction_name'] = (int)$this->getIdActionName();
+        }
+
         foreach($this->actionIdsCached as $field => $idAction) {
             $visitAction[$field] = $idAction;
         }
@@ -307,4 +304,14 @@ public function record($idVisit, $visitorIdCookie, $idReferrerActionUrl, $idRefe
          */
         Piwik::postEvent('Tracker.recordAction', array($trackerAction = $this, $visitAction));
     }
+
+    /**
+     * @return bool
+     */
+    protected function isActionHasActionName()
+    {
+        return in_array($this->getActionType(), array(Tracker\Action::TYPE_PAGE_TITLE,
+                                                      Tracker\Action::TYPE_PAGE_URL,
+                                                      Tracker\Action::TYPE_SITE_SEARCH));
+    }
 }