Removing Smarty strings from codebase, fixing install

Adding twig to LEGALNOTICE
Refs #4019

LEGALNOTICE

@@ -178,9 +178,9 @@ THIRD-PARTY COMPONENTS AND LIBRARIES
 	Link:  http://www.getrank.org/free-pagerank-script
 	License:  GPL
 
-	Name:  Smarty
-	Link:  http://smarty.net/
-	License:  LGPL v2.1 or later
+	Name:  Twig
+	Link:  http://twig.sensiolabs.org/
+	License:  BSD
 
 	Name:  TCPDF
 	Link:  http://sourceforge.net/projects/tcpdf

config/global.ini.php

@@ -494,21 +494,6 @@
 ; disabled by default as it can cause serious overhead and should only be used wisely
 ;logger_api_call[] = file
 
-[smarty]
-; the list of directories in which to look for templates
-template_dir[] = plugins
-template_dir[] = themes/default
-template_dir[] = themes
-
-plugins_dir[] = core/SmartyPlugins
-plugins_dir[] = libs/Smarty/plugins
-
-compile_dir = tmp/templates_c
-cache_dir = tmp/cache
-
-; error reporting inside Smarty
-error_reporting = E_ALL|E_NOTICE
-
 [Plugins]
 Plugins[] = CorePluginsAdmin
 Plugins[] = CoreAdminHome

core/FrontController.php

@@ -272,7 +272,9 @@ public function init()
             Piwik_PostEvent('FrontController.dispatchCoreAndPluginUpdatesScreen');
 
             Piwik_PluginsManager::getInstance()->installLoadedPlugins();
-            Piwik::install();
+
+
+//            Piwik_Common::mkdir(PIWIK_USER_PATH . '/' . Piwik_Config::getInstance()->smarty['compile_dir']);
 
             // ensure the current Piwik URL is known for later use
             if (method_exists('Piwik', 'getPiwikUrl')) {

core/Piwik.php

@@ -105,14 +105,6 @@ static public function unprefixClass($class)
         return $class;
     }
 
-    /**
-     * Installation helper
-     */
-    static public function install()
-    {
-        Piwik_Common::mkdir(PIWIK_USER_PATH . '/' . Piwik_Config::getInstance()->smarty['compile_dir']);
-    }
-
     /**
      * Uninstallation helper
      */

core/Twig.php

@@ -68,7 +68,7 @@ protected function addFunction_includeAssets()
     {
         $includeAssetsFunction = new Twig_SimpleFunction('includeAssets', function ($params) {
             if (!isset($params['type'])) {
-                throw new Exception("The smarty function includeAssets needs a 'type' parameter.");
+                throw new Exception("The function includeAssets needs a 'type' parameter.");
             }
 
             $assetType = strtolower($params['type']);
@@ -173,7 +173,7 @@ protected function addFilter_money()
     {
         $moneyFilter = new Twig_SimpleFilter('money', function ($amount) {
             if (func_num_args() != 2) {
-                throw new Exception('the smarty modifier money expects one parameter: the idSite.');
+                throw new Exception('the money modifier expects one parameter: the idSite.');
             }
             $idSite = func_get_args();
             $idSite = $idSite[1];

core/ViewDataTable.php

@@ -66,7 +66,7 @@ abstract class Piwik_ViewDataTable
     protected $variablesDefault = array();
 
     /**
-     * Array of properties that are available in the view (from smarty)
+     * Array of properties that are available in the view
      * Used to store UI properties, eg. "show_footer", "show_search", etc.
      *
      * @var array

core/ViewDataTable/HtmlTable/Goals.php

@@ -138,7 +138,6 @@ public function setColumnsToDisplay($columnsNames)
                 foreach ($goals as $goal) {
                     $idgoal = $goal['idgoal'];
 
-                    // Columns names are escaped in smarty via | escape:'html'
                     $goal['name'] = Piwik_Common::unsanitizeInputValue($goal['name']);
 
                     if ($this->processOnlyIdGoal > Piwik_DataTable_Filter_AddColumnsProcessedMetricsGoal::GOALS_FULL_TABLE

lang/en.php

@@ -556,7 +556,7 @@
     'CoreHome_DonateCall3'                                              => 'If you feel that Piwik has added significant value to your business or endeavour, %1$splease consider donating!%2$s',
     'CoreHome_HowMuchIsPiwikWorth'                                      => 'How much is Piwik worth to you?',
     'CoreHome_SupportPiwik'                                             => 'Support Piwik!',
-    'CoreHome_OnlyForAdmin'                                             => 'This is only displayed to you, the superuser.',
+    'CoreHome_OnlyForAdmin'                                             => 'This widget is only displayed to you, the superuser.',
     'CoreHome_DonateFormInstructions'                                   => 'Click on the slider to select an amount, then click subscribe to donate.',
     'CoreHome_SubscribeAndBecomePiwikSupporter'                         => 'Proceed to a secure credit card payment page (Paypal) to become a Piwik Supporter!',
     'CoreHome_CheckPiwikOut'                                            => 'Check Piwik out!',

plugins/Installation/Controller.php

@@ -426,7 +426,6 @@ public function displayJavascriptCode()
         $viewTrackingHelp->idSite = $idSite;
         $viewTrackingHelp->piwikUrl = Piwik_Url::getCurrentUrlWithoutFileName();
 
-        // Assign the html output to a smarty variable
         $view->trackingHelp = $viewTrackingHelp->render();
         $view->displaySiteName = $siteName;
 

plugins/Installation/templates/displayJavascriptCode.twig

@@ -8,7 +8,7 @@
 </span>
 {% endif %}
 
-{{ trackingHelp }}
+{{ trackingHelp|raw }}
 <br/><br/>
 <h2>{{ 'Installation_LargePiwikInstances'|translate }}</h2>
 {{ 'Installation_JsTagArchivingHelp1'|translate('<a target="_blank" href="http://piwik.org/docs/setup-auto-archiving/">','</a>')|raw }}

plugins/SitesManager/templates/displayJavascriptCode.twig

@@ -3,5 +3,7 @@
 {% block content %}
 {{ loadJavascriptTranslations(['SitesManager']) }}
 
+{% raw %}
 {% include "@SitesManager/_displayJavascriptCode.twig" %}
+{% endraw %}
 {% endblock %}