Refs #4990 remove Protocol section from system check

matomo-org · May 4, 2014 · cef8bd5 · cef8bd5
1 parent abe158d
commit cef8bd5
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 30 deletions.
diff --git a/core/ProxyHeaders.php b/core/ProxyHeaders.php
@@ -22,10 +22,6 @@ class ProxyHeaders
      */
     public static function getProtocolInformation()
     {
-        if (Common::getRequestVar('clientProtocol', 'http', 'string') == 'https') {
-            return 'https';
-        }
-
         if (isset($_SERVER['SERVER_PORT']) && $_SERVER['SERVER_PORT'] == 443) {
             return 'SERVER_PORT=443';
         }

diff --git a/lang/en.json b/lang/en.json
@@ -1135,8 +1135,6 @@
         "SystemCheckPdoAndMysqliHelp": "On a Linux server you can compile php with the following options: %1$s In your php.ini, add the following lines: %2$s",
         "SystemCheckPhp": "PHP version",
         "SystemCheckPhpPdoAndMysqli": "More information on: %1$sPHP PDO%2$s and %3$sMYSQLI%4$s.",
-        "SystemCheckSecureProtocol": "Secure protocol",
-        "SystemCheckSecureProtocolHelp": "It appears you're using https with your web server. These lines will be added to config\/config.ini.php:",
         "SystemCheckSplHelp": "You need to configure and rebuild PHP with the Standard PHP Library (SPL) enabled (by default).",
         "SystemCheckSummaryNoProblems": "Huzzah! There are no problems with your Piwik setup. Give yourself a pat on the back.",
         "SystemCheckSummaryThereWereErrors": "Uh-oh! Piwik has detected some %1$scritical issues%2$s with your Piwik setup. %3$sThese issues should be fixed immediately.%4$s",

diff --git a/plugins/Installation/Controller.php b/plugins/Installation/Controller.php
@@ -476,15 +476,27 @@ private function createConfigFile($dbInfos)
         if (count($headers = ProxyHeaders::getProxyHostHeaders()) > 0) {
             $config->General['proxy_host_headers'] = $headers;
         }
+
+        if (Common::getRequestVar('clientProtocol', 'http', 'string') == 'https') {
+            $protocol = 'https';
+        } else {
+            $protocol = ProxyHeaders::getProtocolInformation();
+        }
+
+        if (!empty($protocol)
+            && !\Piwik\ProxyHttp::isHttps()) {
+            $config->General['assume_secure_protocol'] = '1';
+        }
+
         $config->General['salt'] = Common::generateUniqId();
         $config->General['installation_in_progress'] = 1;
 
         $config->database = $dbInfos;
         if (!DbHelper::isDatabaseConnectionUTF8()) {
             $config->database['charset'] = 'utf8';
         }
-        $config->forceSave();
 
+        $config->forceSave();
     }
 
     private function checkPiwikIsNotInstalled()

diff --git a/plugins/Installation/SystemCheck.php b/plugins/Installation/SystemCheck.php
@@ -177,11 +177,6 @@ public static function getSystemInformation()
 
         $infos['tracker_status'] = Common::getRequestVar('trackerStatus', 0, 'int');
 
-        $infos['protocol'] = ProxyHeaders::getProtocolInformation();
-        if (!\Piwik\ProxyHttp::isHttps() && $infos['protocol'] !== null) {
-            $infos['assume_secure_protocol'] = '1';
-        }
-
         // check if filesystem is NFS, if it is file based sessions won't work properly
         $infos['is_nfs'] = Filesystem::checkIfFileSystemIsNFS();
         $infos = self::enrichSystemChecks($infos);

diff --git a/plugins/Installation/templates/_systemCheckSection.twig b/plugins/Installation/templates/_systemCheckSection.twig
@@ -288,18 +288,6 @@
         </td>
     </tr>
     {% endif %}
-    {% if infos.assume_secure_protocol is defined %}
-        <tr>
-            <td class="label">{{ 'Installation_SystemCheckSecureProtocol'|translate }}</td>
-            <td>
-                {{ warning }} <span class="warn">{{ infos.protocol }} </span><br/>
-                {{ 'Installation_SystemCheckSecureProtocolHelp'|translate }}
-                <br/><br/>
-                <code>[General]<br/>
-                    assume_secure_protocol = 1</code><br/>
-            </td>
-        </tr>
-    {% endif %}
     {% if infos.extra.load_data_infile_available is defined %}
         <tr>
             <td class="label">{{ 'Installation_DatabaseAbilities'|translate }}</td>

diff --git a/plugins/Installation/templates/systemCheck.twig b/plugins/Installation/templates/systemCheck.twig
@@ -1,6 +1,16 @@
 {% extends '@Installation/layout.twig' %}
 
 {% block content %}
+
+<script type="text/javascript">
+    $(function () {
+        // client-side test for https to handle the case where the server is behind a reverse proxy
+        if (document.location.protocol === 'https:') {
+            $('p.nextStep a').attr('href', $('p.nextStep a').attr('href') + '&clientProtocol=https');
+        }
+    });
+</script>
+
 {% if not showNextStep %}
     {% include "@Installation/_systemCheckLegend.twig" %}
     <br style="clear:both;">

diff --git a/plugins/Installation/templates/welcome.twig b/plugins/Installation/templates/welcome.twig
@@ -16,11 +16,6 @@
 <script type="text/javascript">
     <!--
     $(function () {
-        // client-side test for https to handle the case where the server is behind a reverse proxy
-        if (document.location.protocol === 'https:') {
-            $('p.nextStep a').attr('href', $('p.nextStep a').attr('href') + '&clientProtocol=https');
-        }
-
         // client-side test for broken tracker (e.g., mod_security rule)
         $('p.nextStep').hide();
         $.ajax({

diff --git a/tests/PHPUnit/UI b/tests/PHPUnit/UI