-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top navigation in General Settings no longer working #18663
Comments
I'm not able to reproduce that locally. Also not with disabled developer mode and the same set of plugins. It seems somehow the locationchange doesn't trigger the anchorfix on demo2 as calling |
Unfortunately I don't have access to the settings page on demo2. I can try reproducing locally. |
@diosmosis let us know if you need access to demo2 to check that there. |
Wasn't able to find the cause but I would look at this code: https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/CoreHome/angularjs/anchorLinkFix.js#L92-L103 |
@tsteur Seems neither me, nor @diosmosis are able to reproduce that locally. So might be hard to find the reason. @diosmosis I can give you super user access on demo2 if that helps. If you need ssh access to check if some changes are helping, guess @tsteur can help. I don't have ssh access to demo2. |
I have ssh access to demo2 if I need to change anything. |
@diosmosis I just gave you super user access. Feel free to check if you can find the reason... |
Looks like the $locationChangeStart event is not even triggered. I'm guessing somewhere in angularjs it's not noticing the update to the hash. I've seen this before but wasn't able to non-intrusively fix it. |
Something off w/ the angularjs bootstrap logic. |
@sgiehl This line is what fails in demo2 but works locally:
On demo2 |
Nevermind, that's not the reason... still looking. |
@sgiehl / @tsteur ok, I can reproduce: if you disable GoogleAnalyticsImporter locally (and potentially any other plugin that uses the $location service in a run/config), the behavior is reproducible. |
@diosmosis good catch. Guess this was caused by migrating some stuff to vue then, as the |
@sgiehl I think you'd need a run block:
|
If sticking it in Vue code would put it in MatomoUrl.adapter.ts since it's to get angularjs initialized properly there. |
This seems to be broken for me on demo2 https://demo2.matomo.org/index.php?module=CoreAdminHome&action=generalSettings&idSite=1&period=day&date=yesterday and locally but it works on demo.matomo.org
Looks like a regression in a recent change maybe?
When I click on one of these links then it doesn't jump to the correct settings
The text was updated successfully, but these errors were encountered: