Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to Github Actions to run our CI #20179

Closed
mattab opened this issue Jan 9, 2023 · 1 comment · Fixed by #18679
Closed

Migrate from Travis CI to Github Actions to run our CI #20179

mattab opened this issue Jan 9, 2023 · 1 comment · Fixed by #18679
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 9, 2023

as per title

work done in #18679

Steps

  • Update Global action to deal with Missing dependencies in some builds
  • Update console command to generate the file. So that it's easy to update the Travis files. So you can create github action file by using a command. so it's easy to push the github actions to all available plugins without manually coping the github action files
  • check if Github builds at least as fast as travis? and report the runtime here to compare
  • we make it work for Matomo core
    • and also for the other repositories under the team
    • and we provide basic instructions to colleagues on how to convert a plugin repo to github
  • Update the guides that mention Travis to replace with Github and fix appropriately -> Delete any outdated content and write a very basic guide on how Github works
  • Document how to handle dependencies in a plugin
    • eg. how would it work for LDAP plugin for example "LoginLdap, for example, tests itself against a live LDAP server and thus needs to install and setup OpenLDAP on travis. To accomplish this, LoginLdap adds extra steps to its generated .travis.yml file." -> how would we do this on github action? Yes, with a local action it's possible.

Notes:

  • we don't fix random failing tests for now
  • we do fix any tests that consistently fail
@mattab mattab added this to the 4.13.1 milestone Jan 9, 2023
@sgiehl sgiehl self-assigned this Jan 9, 2023
@justinvelluppillai justinvelluppillai modified the milestones: 4.13.1, 4.13.2 Jan 11, 2023
@sgiehl sgiehl modified the milestones: 4.13.2, 4.13.3, 4.13.4 Jan 25, 2023
@sgiehl sgiehl linked a pull request Jan 31, 2023 that will close this issue
11 tasks
@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2023

GitHub test action is now running for 4.x-dev branch. Travis tests will still run in parallel (except UI tests).
Will create another PR to remove travis tests (including the sumbodule) for 5.x-dev branch. So support for travis ci will be dropped with Matomo 5.

@bx80 bx80 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants