-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create & use API for coding UI controls that spans PHP/JavaScript #4116
Comments
Would the value be for core devs, or would this improvement also help plugin developers? |
In 6d884e1: Refs #3089, #4116, display visitor profile popup when visit in realtime map is clicked. Notes:
|
We will continue this work and move to use more AngularJS based solutions, which have cool advantages like unit testing, dependency injections. In general we'll aim to build a light client app in Javascript, and the server side will move to APIs (almost no controllers). See ticket AngularJS in Piwik #4691 |
…when visit in realtime map is clicked. Notes: - Includes new UIControl base type. - Fixes cleanup bugs in realtime map and popover closing. - Refactored realtime map so as little JavaScript as possible is included in HTML fragments. - Allow more than one realtime map to exist on a single page.
At the moment, there is no set of practices/concepts that guide the way UI controls are coded. The general process to add one seems to be:
This works, but results in messy, unclear code and does not make reusing controls easy. I think a better way to organize code (across both JavaScript & PHP) is to architect UI controls like this:
The text was updated successfully, but these errors were encountered: