Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Meta tag IE=edge for best security practises #5282

Closed
mattab opened this issue Jun 2, 2014 · 2 comments
Closed

Include Meta tag IE=edge for best security practises #5282

mattab opened this issue Jun 2, 2014 · 2 comments
Assignees
@mattab
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.4.0

Comments

@mattab
Copy link
Member

mattab commented Jun 2, 2014

From email:

I was reviewing the code and notice that you all don't include <meta http-equiv="x-ua-compatible" content="IE=edge" > in your headers. Piwik admin does not show up correctly in my IE without that meta tag. IE11 will try to render a page like IE7 if the meta tag is missing. This is a security risk because it is not using the latest security updates.( http://www.modern.ie/en-us/performance/how-to-use-x-ua-compatible) Can you all please add these meta tag to all headers?

This was also discussed in: #4620

Do we need to add this meta tag to Login + Dashboard + Admin headers?
@mattab
Copy link
Member Author

mattab commented Jun 4, 2014

In e1f3209: Merge pull request #302 from LGarciaSpherexx/bugfix

Fixes #5282
Thanks for the pull request! could you please let me know, in case you have not tested this change?

@mattab
Copy link
Member Author

mattab commented Jun 4, 2014

In abfe0f6: Make the X-UA-Compatible consistent across piwik codebase
Refs #302
refs #5282

@mattab mattab added this to the 2.4.0 - Piwik 2.4.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@mattab