-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoIP2 #10431
GeoIP2 #10431
Conversation
use ISO codes for US and CA, use uppercase for continent, country and region codes.
Thanks for the PR. Haven't tested it, but wouldn't it be possible to move this integration into a new plugin? Maybe we need to make some tweeks in current code to handle that easier... |
Thank you @diabl0 for your contribution! Stefan improved a bit the platform in #10523 so that you can now define Location providers in plugins. This lets you add your useful GeoIP2 support in a plugin which would be available on the marketplace.
Could we maybe help you with this? For example, we can buy the database and send them to you... It is very awesome feature that many users will love and if we can help in this way it would be a pleasure! Let us know what you think. Thanks |
You may need to use Piwik 3 from git |
It wasn't documented when i wrote it that's why I made this changes. I will try to look at this sometime next week and convert into plugin. |
@diabl0 it wasn't actually implemented, and your pull request made us realise about it. So that's all good! Thanks for trying to convert to a plugin. Let us know if you have any trouble |
Closing the pull request for now, as @diabl0 will try to create a plugin on the marketplace for this nice improvement. |
MaxMind GeoIP2 location provider for UserCountry plugin.
Requires geoip2/geoip2 package and provides support for GeoIP2 mmdb files.
Requires present one of files in misc directory:
Also added ISO-3166-2 region codes to FIPS 10.2 conversion
Unfortunately i don't have access to other databases so no support for them.