New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace improvements #10737
Marketplace improvements #10737
Conversation
@sgiehl do you have an idea why |
Conflicts: tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png tests/UI/expected-screenshots/UIIntegrationTest_admin_themes.png tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
Conflicts: tests/UI/expected-screenshots/UIIntegrationTest_admin_plugins.png tests/UI/expected-screenshots/UIIntegrationTest_admin_themes.png tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
@@ -20,9 +20,18 @@ class Menu extends \Piwik\Plugin\Menu | |||
{ | |||
private $marketplacePlugins; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsteur as there are now such nice and complete UI tests & fixture for the Marketplace, would it maybe be do-able to add a single UI test for this " counter-plugins-to-update displayed-in-menu" feature?
Updated the only FAQ that mentioned enable_marketplace: How do I configure Piwik on a server without Internet? |
|
||
return array( | ||
'MarketplaceEndpoint' => function (ContainerInterface $c) { | ||
// if you wonder why this here is configured here again, and the same as in `config.php`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so thoughtful Thomas 😃
So much code, so many tests... beautifully hand crafted quality software! This Epic pull request 💥 is going to be merged NOW! 🎉 |
fixes #10695
This update brings many new features:
multi_server_environment
to specify whether Piwik is running in a multi server environment. If so, we disable some features like installing plugins from the Marketplace directly as it would be only installed on one server instead of all of them. Instead they are able to download. Same for plugin updates. This will be also useful later for things that changes config entries etc[General]enable_marketplace=0/1
is now disabled and instead we are using the plugin enabled/activated to disable the Marketplace. The updater respects a setting where the Marketplace is already disabled and it won't enable the Marketplace in this case$coreUpdater->isUpdatingOverHttps()
)