Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace improvements #10737

Merged
merged 29 commits into from
Oct 22, 2016
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
01911a3
Marketplace updates
tsteur Oct 13, 2016
67624e4
fix some tests
tsteur Oct 13, 2016
f5432b9
fix typo
tsteur Oct 13, 2016
702bd3c
fix some more ui tests
tsteur Oct 13, 2016
a497b37
fix some tests
tsteur Oct 13, 2016
94783d8
Updated submodules to latest 2.x-dev tip
mattab Oct 20, 2016
c1e7010
Marketplace improvements will be in 2.17.0-b2
mattab Oct 20, 2016
68eafc1
UI tests: no link on Gpl license
mattab Oct 20, 2016
2073fe0
Merge branch 'updated_submodules' into pluginsmarketplace
mattab Oct 20, 2016
2fd58f7
license key, and link on premium plugins
mattab Oct 21, 2016
f1aa6b8
Show button on premium plugins not activated yet
mattab Oct 21, 2016
2cc2e14
Minor tweaks to some labels in the UI
mattab Oct 21, 2016
5e01fd5
make sure plugin updates are shown in menu
tsteur Oct 20, 2016
611fc6d
we do not count anonymous user as a user when assessing number of aut…
mattab Oct 21, 2016
2583fdb
integration tests expected strings
mattab Oct 21, 2016
8897611
integration tests expected strings
mattab Oct 21, 2016
da063f9
Delete this file as it fails the test for some unknown reasons ping @…
mattab Oct 21, 2016
01dc76d
UI screenshots after marketplace tweaks & one fix
mattab Oct 21, 2016
b0a4724
consistent bold in CTA link
mattab Oct 21, 2016
7bb192e
Merge remote-tracking branch 'origin/2.x-dev' into pluginsmarketplace
mattab Oct 21, 2016
cb68955
UI tests
mattab Oct 22, 2016
218f3d7
unused string
mattab Oct 22, 2016
407f76b
gst -> tax
mattab Oct 22, 2016
ea2b709
minor tweak
mattab Oct 22, 2016
efe842a
do not show example link so SU don't delete license in one click by m…
mattab Oct 22, 2016
0e9dd01
api description
mattab Oct 22, 2016
598ec31
minor tweaks
mattab Oct 22, 2016
eaa948a
add link to FAQ in footer
mattab Oct 22, 2016
333fb48
italic is not allowed ;-)
mattab Oct 22, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 12 additions & 3 deletions plugins/CorePluginsAdmin/Menu.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/
namespace Piwik\Plugins\CorePluginsAdmin;

use Piwik\Db;
use Piwik\Container\StaticContainer;
use Piwik\Menu\MenuAdmin;
use Piwik\Piwik;
use Piwik\Plugins\Marketplace\Marketplace;
Expand All @@ -20,9 +20,18 @@ class Menu extends \Piwik\Plugin\Menu
{
private $marketplacePlugins;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsteur as there are now such nice and complete UI tests & fixture for the Marketplace, would it maybe be do-able to add a single UI test for this " counter-plugins-to-update displayed-in-menu" feature?


public function __construct(Plugins $marketplacePlugins = null)
/**
* Menu constructor.
* @param Plugins $marketplacePlugins
*/
public function __construct($marketplacePlugins = null)
{
$this->marketplacePlugins = $marketplacePlugins;
if (!empty($marketplacePlugins)) {
$this->marketplacePlugins = $marketplacePlugins;
} elseif (Marketplace::isMarketplaceEnabled()) {
// we load it manually as marketplace plugin might not be loaded
$this->marketplacePlugins = StaticContainer::get('Piwik\Plugins\Marketplace\Plugins');
}
}

public function configureAdminMenu(MenuAdmin $menu)
Expand Down