Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When there is no data for a website, as soon as a visit was detected reload the report for Today #11275

Merged
merged 4 commits into from
Feb 19, 2017
Merged

When there is no data for a website, as soon as a visit was detected reload the report for Today #11275

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1584697
Cross Domain: forward pk_vid parameter when the clicked element is no…
mattab Jan 23, 2017
a72038c
Merge branch '3.x-dev' of github.com:piwik/piwik into 3.x-dev
mattab Jan 25, 2017
ffd6fe1
reload page as soon as a visit was detected should reload Today's report
mattab Jan 25, 2017
3cff539
Use broadcast.propagateNewPage as suggested in review
mattab Feb 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/SitesManager/templates/siteWithoutData.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
interval: 1000,
onUpdate: function () {
// reload page as soon as a visit was detected
document.location.reload();
var urlToday = broadcast.updateParamValue('date=today', window.location.href);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to use propagateNewPage() here? It will make sure the reload will be performed even if angular etc would maybe block it

window.location.href = urlToday;
},
dataUrlParams: {
module: 'Live',
Expand Down