Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert period selector to angular & allow plugins to add periods to the frontend #11873

Merged
merged 32 commits into from
Oct 16, 2017
Merged

Convert period selector to angular & allow plugins to add periods to the frontend #11873

merged 32 commits into from
Oct 16, 2017

Commits on Sep 28, 2017

  1. Configuration menu
    Copy the full SHA
    444cafd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    279937e View commit details
    Browse the repository at this point in the history
  3. Move period selector code from calendar.js to new angular directive (…

    …just move, no refactoring).
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    d7a1676 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4de104b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a3be407 View commit details
    Browse the repository at this point in the history
  6. Extract single period calendar to separate component & extract period…

    … specific functionality to new extendable periods service.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    034ca3a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1d1d269 View commit details
    Browse the repository at this point in the history
  8. Move bulk of period selector code from directive to controller, & fix…

    … variable name in date range picker template.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    765753e View commit details
    Browse the repository at this point in the history
  9. Fix issue w/ yesterday date value, remove need to give period selecto…

    …r directive translations and make sure periods can be extended in the frontend.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    0edd007 View commit details
    Browse the repository at this point in the history
  10. Make sure period selector still works outside of an angular routing c…

    …ontext (ie, in embedded dashboard).
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    cba43a1 View commit details
    Browse the repository at this point in the history
  11. In period selector UI test, hide ajaxLoadingCalendar using CSS since …

    …it is now managed by angular.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    dbb0030 View commit details
    Browse the repository at this point in the history
  12. Make sure selected period highlighting changes immediately after sele…

    …cting, even if loading a new page.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    c0c8c73 View commit details
    Browse the repository at this point in the history
  13. Put period selector top level element ID & classes on correct element…

    …s to ensure certain styles work properly.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    25ae3fe View commit details
    Browse the repository at this point in the history
  14. Make sure selected period text changes immediately after selecing per…

    …iod, even if loading a new page or changing the URL.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    7e77422 View commit details
    Browse the repository at this point in the history
  15. Make sure range start/end changes immediately when a period is select…

    …ed & selected period date range stops being highlighted immediately when a range period is selected, even if loading a new page.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    522d97e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    eb18d6d View commit details
    Browse the repository at this point in the history
  17. Updating screenshots.

    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    e50c2c0 View commit details
    Browse the repository at this point in the history
  18. Assorted fixes for period selector refactor.

    - Filter out invalid period labels (can happen if INI config for allowed periods is incorrect).
    - When determining display text for range, don't try to format the startRangeDate/endRangeDate vars, they're both strings.
    - Use correct selector when closing period selector.
    diosmosis committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    cc290ea View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2017

  1. Set global piwik date/period values on location change, outside of pe…

    …riod selector component.
    diosmosis committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    3637932 View commit details
    Browse the repository at this point in the history
  2. Do not skip parsing date if it does not start with an int (since the …

    …JS can handle today/yesterday/now).
    diosmosis committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    1981c0b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Assorted fixes for period selector refactor:

    - use $onChanges instead of watches in datepicker (watches get triggered every time, $onChanges doesn't)
    - don't use arrays for selected/highlighted dates (for some weird reason, changing one of these arrays results in angular thinking it changes 3 times instead of once)
    - don't redraw on triggered mouseover events (something triggers mouseover when a date is selected, probably jquery datepicker)
    - draw after a setTimeout when a date is selected so our drawing occurs after jquery datepicker draws
    diosmosis committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    78aa0ca View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Achieving smoother rendering for period selector by removing click ha…

    …ndlers jquery datepicker adds.
    
    Also fixed bug where selecting the current period type reset the view date for the date picker.
    diosmosis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    cd06459 View commit details
    Browse the repository at this point in the history
  2. Bound range date in period selector by piwik min/max date, so inferre…

    …d dates will always be within allowed pickable dates in picker.
    diosmosis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    7ad0aa8 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2017

  1. Removing ES6 used by accident + fix for issue when switching from non…

    …-year to year period (ui-datepicker-current-day class does not get removed).
    diosmosis committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    77af67b View commit details
    Browse the repository at this point in the history
  2. Fix for angularjs one way binding quirk: initial property value is se…

    …t before $onInit not during construction.
    diosmosis committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    ce4c5da View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2017

  1. Configuration menu
    Copy the full SHA
    0027233 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2017

  1. Configuration menu
    Copy the full SHA
    d9c4e0f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2017

  1. Configuration menu
    Copy the full SHA
    337cf0b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2017

  1. Configuration menu
    Copy the full SHA
    34ad366 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de7ed86 View commit details
    Browse the repository at this point in the history
  3. Only hide period option tooltip if period is active period, not if pe…

    …riod is selected period.
    diosmosis committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    1652eb1 View commit details
    Browse the repository at this point in the history
  4. In period selector, disable apply button if range is invalid. Also fi…

    …x case when \$.datepicker.parseDate returns null instead of throwing.
    diosmosis committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    f1ddf3b View commit details
    Browse the repository at this point in the history