-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New method setSecureCookie
that sets the cookie secure parameter
#11891
Conversation
@sgiehl I need help. My test is failing. The output states that a method I implemented (and defined in piwiktest.js) does not exists. I need a light on this. |
You need to add the method names to the method listing in line 989 |
@sgiehl Thanks man! Now the tests are passing and the updated js is minified. |
@sgiehl Hey Stefan! All good now? |
Guess the method |
@sgiehl done! |
Looks good to merge for me now. |
|
setSecureCookie
that sets the cookie secure parameter
Thanks @dudu84 for a great PR! |
Note: this feature wasn't working, but this PR hopefully fixes it: #12355 |
Fix #11410
Please issue pull request against the
3.x-dev
branch only.Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.
If you need to create a pull request for 2.x, then please also create the pull request against the
3.x-dev
so we can merge both.Happy hacking!