Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method `setSecureCookie` that sets the cookie secure parameter #11891

Merged
merged 1 commit into from Aug 3, 2017

Conversation

@ghost
Copy link

ghost commented Jul 24, 2017

Fix #11410

Please issue pull request against the 3.x-dev branch only.

Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.

If you need to create a pull request for 2.x, then please also create the pull request against the 3.x-dev so we can merge both.

Happy hacking!

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 24, 2017

@sgiehl I need help. My test is failing. The output states that a method I implemented (and defined in piwiktest.js) does not exists. I need a light on this.

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Jul 24, 2017

You need to add the method names to the method listing in line 989

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 24, 2017

@sgiehl Thanks man! Now the tests are passing and the updated js is minified.

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 26, 2017

@sgiehl Hey Stefan! All good now?

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Jul 27, 2017

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 31, 2017

@sgiehl done!

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Aug 1, 2017

Looks good to merge for me now.
@mattab Shall we merge before releasing 3.0.5? Or wait for 3.1.0?

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Aug 2, 2017

  • Please add the new function in the CHANGELOG.md file so the new method will appear in our developer changelog @ http://developer.piwik.org/changelog
  • Once done LGTM to merge for 3.0.5
@mattab mattab changed the title Fix #11410: Optional secure tracker cookie New method `setSecureCookie` that sets the cookie secure parameter Aug 3, 2017
@mattab

This comment has been minimized.

Copy link
Member

mattab commented Aug 3, 2017

Thanks @dudu84 for a great PR!

@mattab mattab merged commit 2873206 into matomo-org:3.x-dev Aug 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Aug 3, 2017

@sgiehl and @mattab It's me who thank you guys for the patience and the opportunity to learn.

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Dec 13, 2017

Note: this feature wasn't working, but this PR hopefully fixes it: #12355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.