New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default DB table prefix #12416

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Jan 9, 2018

We will need to see whether tests fail and how easy we can fix them etc.

refs #12420

@tsteur tsteur added the Needs Review label Jan 9, 2018

@mattab mattab added this to the 3.3.0 milestone Jan 10, 2018

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Jan 10, 2018

Member

failing tests should not be related to this... they will be fixed via #12415 . Don't want to fix it here as well as otherwise merge problems.
@mattab I think it would be safe to merge

Member

tsteur commented Jan 10, 2018

failing tests should not be related to this... they will be fixed via #12415 . Don't want to fix it here as well as otherwise merge problems.
@mattab I think it would be safe to merge

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Jan 10, 2018

Member

Since it affects only new users installing, and also the other default prefix in global.ini.php is empty, this is safe and looks good 👍

Member

mattab commented Jan 10, 2018

Since it affects only new users installing, and also the other default prefix in global.ini.php is empty, this is safe and looks good 👍

@mattab mattab merged commit 94ba5f2 into 3.x-dev Jan 10, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@sgiehl sgiehl deleted the matomo_db_table_prefix branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment