-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run AllTests on PHP8 #16897
Run AllTests on PHP8 #16897
Conversation
a4f0a32
to
0869f11
Compare
@tsteur the tests are running now on PHP 8. But I needed to update to PHPUnit 9 for that build, as PHPUnit 8.5 doesn't support PHP 8. Unfortunately PHPUnit 9 doesn't support PHP < 7.3, so we can't update in general. Nevertheless there seem a lot tests failing. Would need some time to investigate that a bit further. Let me know if or when I should plan to do that. |
ade2b73
to
f9482e3
Compare
@sgiehl it seems to be mostly working? we could look into it as part of 4.1 if it's somewhat quick to do to fix these issues. For now priority is 4.0.X and I think I pinged you on few other sec issues etc |
@tsteur Actually might be a bit more. The second build that is shown as success actually silently fails. See https://travis-ci.com/github/matomo-org/matomo/jobs/455444024#L996 |
4bde232
to
df86948
Compare
cc3a2f6
to
3769f1f
Compare
Some tests are failing due to adjustments required in TCPDF. Those should be fixed with tecnickcom/TCPDF#293 |
109b850
to
e8d49b3
Compare
This should now be ready for a review. Had to change a couple of tests in order to make them run on PHP 7 & PHP 8, but now the only remaining failing tests also fail on 4.x-dev... Note: Once we raised the requirement for Matomo to PHP 7.3 or higher, we can remove the special handling for PHP 8 tests again and update PHPUnit globally, as newer version of PHPUnit are not compatible with PHP 7.2. |
…known named parameters
👍 looks good. Great to have it working 🎉 |
Description:
Runs AllTests on PHP 8 instead of PHP 7.4
Review