-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16990 export url token #17227
16990 export url token #17227
Conversation
plugins/CoreHome/angularjs/report-export/reportexport.directive.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found one possible issue
@@ -61,7 +61,8 @@ | |||
</div> | |||
|
|||
<div class="col l12" ng-show="showUrl"> | |||
<textarea piwik-select-on-focus readonly class="exportFullUrl" title="{{ 'CoreHome_ExportTooltip'|translate }}">{{ getExportLink() }}</textarea> | |||
<textarea piwik-select-on-focus readonly class="exportFullUrl">{{ getExportLinkWithoutToken() }}</textarea> | |||
<div class="tooltip" ng-bind-html="'CoreHome_ExportTooltipWithLink'|translate:'<a target=_blank href=\'/index.php?module=UsersManager&action=userSecurity\'>':'</a>':'ENTER_YOUR_TOKEN_AUTH_HERE'"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL starting w/ /index.php
will break on subdirectory installs, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks. I'll check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @diosmosis I fixed this, using directory-relative URL instead of origin-relative.
Description:
fix for #16990
Review