-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix regression in trackingspamprevention and warning in bound parameter checking code #17683
Conversation
core/bootstrap.php
Outdated
@@ -37,6 +37,7 @@ | |||
@date_default_timezone_set('UTC'); | |||
|
|||
disableEaccelerator(); | |||
printTestDoxHint(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that currently printed in any case. Shouldn't that only be shown when running tests and if testdox isn't enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgiehl I can add this, but given testdox will rarely be used, and will only be set manually, I didn't think it was worth the added complexity. Let me know if this is still an important change.
Also note: after merging, TrackingSpamPrevention's minimum required matomo will need to be updated |
The problem is that most tests are failing. Guess it might make more sense
to move that to the console command that runs the tests maybe
|
@sgiehl I see, nevermind, phpstorm gave me the wrong bootstrap file. It should be in the test's bootstrap.php. |
Description:
Changes:
Review