[Vue] Add support for scoped styles (though they will not be able to access theme variables). #18287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Noticed that my understanding of how Vue implements scoped styles was incorrect. I assumed it worked like Emotion, but for production Vue will generate a CSS file. So we can use scoped styles w/o increasing the JS bundle size.
Note, however, that theme variables defined in the normal Matomo asset pipeline are not available here, so it will be of limited use. For the migration I won't be moving them.
Review