-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] migrate piwik-widget and related directives #18429
Conversation
…l erase modal content when initializing NotificationGroup component.
UI tests should be passing for this PR |
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl I'll fix these in the other branches individually. I will have limited availability however for the next couple weeks, so it's ok to do one Vue review a day (if there's a PR to review) in my opinion. I won't have time to get to everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and I wasn't able to find any related issues while clicking through the UI
Description:
This PR is based off of #18428.
Changes:
Review