-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from marketplace #19416
Conversation
…org/matomo into vue-remove-angularjs-Marketplace
…hen internet access is not available and the Marketplace plugin is deactivated
…angularjs-Marketplace
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet finished with the review, but already want to leave the stuff I've found. Might add more comments if anything else doesn't work.
Edit: Review finished. haven't found anything else.
plugins/CorePluginsAdmin/vue/src/PluginsTable/PluginsTableWithUpdates.vue
Outdated
Show resolved
Hide resolved
plugins/CorePluginsAdmin/vue/src/PluginsTable/PluginsTableWithUpdates.vue
Outdated
Show resolved
Hide resolved
plugins/Marketplace/vue/src/GetNewPluginsAdmin/GetNewPluginsAdmin.vue
Outdated
Show resolved
Hide resolved
…org/matomo into vue-remove-angularjs-Marketplace
@sgiehl applied more fixes |
1341918
to
19e089e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't find any further issues...
* start removing angularjs from Marketplace plugin * finish removing angularjs from marketplace and some twig templates in CorePluginsAdmin * built vue files * fixing UI tests locally * add missing translations * couple small UI test fixes * move UploadPluginDialog to CorePluginsAdmin so it will be available when internet access is not available and the Marketplace plugin is deactivated * revert last tweak * styling tweak * Allow composer plugins for dev dependency codesniffer to fix travis builds. * styling tweaks * comma spacing tweak * update screenshots + fix v-show condition * remove duplicate tokens * remove use of unneeded twig escape filter html_attr * apply review feedback + fix some other issues found while testing quickly * updates expected test files Co-authored-by: sgiehl <stefan@matomo.org>
Description:
Changes:
Review