-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty excludedReferrers on the global setting #19834
Conversation
allow emply excludedReferrers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might maybe be worth adding a test case for storing an empty value, to ensure the solution really works.
add some tests for set refer and update isLookLikeUrl function
@sgiehl that makes more sense, add a couple of tests, just wondering |
update phpcs
revert Urlhelper, implement in api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterhashair example a
might not be a valid record but we need to take care to be not too restrictive, as this might produce new problems.
remove filter_var tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the code indent, that was wrong after your changes. Looks good now.
Description:
Fixes: #19833
allow empty excludedReferrers on the global setting
Also, I notice when the setting changed successfully, there is no notification popup, should we add one?
Review