Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract database specific helper methods to adapters #20097

Closed
wants to merge 4 commits into from

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Dec 13, 2022

Description:

Fixes #19648

Moves all MySQL specific code from core/Db, core/DbHelper and all classes under core/Db/ to the database adapter classes core/Adapter/Pdo/Mysql, core/Adapter/Mysqli and a new shared class core/AdapterMysqlAdapterCommon` for methods common for both.

Updates for tracker Db classes core/Tracker/Db, core/Tracker/Db/Pdo/Mysql and core/Tracker/Db/Mysqli are also included.

The overall objective of these changes is to be able to add a new core/Db/Adapter/Pdo/[some new db], core/Db/Schema/[some new db] and core/Tracker/Db/Pdo/[[some new db] where 'some new db' supports prima facie MySQL style queries but has a different underlying architecture with differences in schema, indices, key type, engine type, error codes and session variables.

Review

@bx80 bx80 added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Dec 13, 2022
@bx80 bx80 added this to the 5.0.0 milestone Dec 13, 2022
@bx80 bx80 self-assigned this Dec 13, 2022
@bx80 bx80 removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Dec 15, 2022
@bx80
Copy link
Contributor Author

bx80 commented Dec 16, 2022

Closed in favor of #20112 due to 'not our ref' git error.

@bx80 bx80 closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant