Enhance console command plugin:list with version information #20717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
May 15, 2023
There was a problem hiding this comment.
Hey @ziegenberg
Thanks for this contribution. I've left a couple of comments for certain improvements.
sgiehl
added
the
Enhancement
* Add a column to the plugin information table with the plugin version, when the verbosity level of the console command `plugin:list` is increased (-v). Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
enhance-console-command-list-plugins
branch
from
e8f2507
to
c0079c5
Compare
Co-authored-by: sgiehl <stefangiehl@gmail.com> Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
enhance-console-command-list-plugins
branch
from
c0079c5
to
6c141e7
Compare
|
I applied all the suggested improvements and rebased them onto the current |
sgiehl
approved these changes
May 15, 2023
sgiehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a column to the plugin information table with the plugin version when the verbosity level of the console command
plugin:listis increased (-v).Review