Fix: strnatcasecmp(): Passing null to parameter #1 ($string1) of type string is deprecated

[blankse]

Description:

Since php 8.1 it is deprecated to pass null to the strnatcasecmp() method. The category of the reports can be null.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

@blankse Thanks for creating this PR. Would you mind explaining where the error occurred? Also would you maybe mind to recreate this PR against 5.x-dev.
We won't merge any fixes for 4.x-dev unless it has been fixed for 5.x-dev already, to avoid any fixes from not being included in the next major release. Thanks

[blankse]

@sgiehl I rebased to 5.x-dev

The deprecation warning is skipped by the ErrorHandler. You need to remove this lines to see it:

matomo/core/ErrorHandler.php

Lines 139 to 142 in 952df60

	// if the error has been suppressed by the @ we don't handle the error
	if (!(error_reporting() & $errno)) {
	return;
	}

Or create a Breakpoint in a xdebug session.

I think this should be used only for the @ sign. Here there isn't a @ sign.

I think the @ sign is a bad practice. Often the warnings for not setting array keys can be avoided by ?? null. I can create a additional PR if you want.

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[github-actions]

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

[github-actions]

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers