-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip invalidating yesterday if a proper archive is already in progress #22400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Stability
For issues that make Matomo more stable and reliable to run for sys admins.
labels
Jul 16, 2024
sgiehl
force-pushed
the
skipinvalidationforyesterday
branch
from
July 16, 2024 12:15
ab4ac1f
to
c231373
Compare
sgiehl
force-pushed
the
skipinvalidationforyesterday
branch
2 times, most recently
from
July 16, 2024 12:57
fba3f1b
to
ea2f7a8
Compare
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
July 16, 2024 13:09
acb5b40
to
a516546
Compare
sgiehl
force-pushed
the
skipinvalidationforyesterday
branch
from
July 16, 2024 13:10
ea2f7a8
to
291abb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was contemplating whether the mechanism should moved to invalidateWithSegments
but it is probably ok where it is.
michalkleiner
approved these changes
Jul 17, 2024
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
July 19, 2024 13:58
5311faf
to
607f032
Compare
Co-authored-by: Michal Kleiner <michal@innocraft.com>
sgiehl
force-pushed
the
skipinvalidationforyesterday
branch
from
July 19, 2024 14:00
86a654a
to
234a519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Needs Review
PRs that need a code review
Stability
For issues that make Matomo more stable and reliable to run for sys admins.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our archiving process in the beginning automatically invalidates all data for today and yesterday. This is done to ensure those archives are finally built with all data.
For invalidating yesterday there are already certain restrictions when this will be skipped. If there is already an archive available that was built after midnight, it will be skipped as there won't be any new data to include anyway.
This PR extends those checks to also skip the invalidation if another archiving process is already archiving yesterday and was started after midnight. This prevents that this currently built archive can be invalidated right away before it was even finished.
Review